From 5c7add21761fc6b7d3c0af0819865242ce381960 Mon Sep 17 00:00:00 2001
From: Eugen Rochko <eugen@zeonfederated.com>
Date: Sat, 7 Jan 2017 15:44:22 +0100
Subject: [PATCH] Fix #147 - Unreblogging will leave original status in feeds
---
app/assets/javascripts/components/actions/timelines.jsx | 4 +++-
app/assets/javascripts/components/reducers/timelines.jsx | 9 +++++++--
app/services/remove_status_service.rb | 7 ++++++-
3 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/app/assets/javascripts/components/actions/timelines.jsx b/app/assets/javascripts/components/actions/timelines.jsx
index 0e6f09190d..8bb939d314 100644
--- a/app/assets/javascripts/components/actions/timelines.jsx
+++ b/app/assets/javascripts/components/actions/timelines.jsx
@@ -39,12 +39,14 @@ export function deleteFromTimelines(id) {
return (dispatch, getState) => {
const accountId = getState().getIn(['statuses', id, 'account']);
const references = getState().get('statuses').filter(status => status.get('reblog') === id).map(status => [status.get('id'), status.get('account')]);
+ const reblogOf = getState().getIn(['statuses', id, 'reblog'], null);
dispatch({
type: TIMELINE_DELETE,
id,
accountId,
- references
+ references,
+ reblogOf
});
};
};
diff --git a/app/assets/javascripts/components/reducers/timelines.jsx b/app/assets/javascripts/components/reducers/timelines.jsx
index b73c83e0fb..c5e3a253f5 100644
--- a/app/assets/javascripts/components/reducers/timelines.jsx
+++ b/app/assets/javascripts/components/reducers/timelines.jsx
@@ -145,7 +145,12 @@ const updateTimeline = (state, timeline, status, references) => {
return state;
};
-const deleteStatus = (state, id, accountId, references) => {
+const deleteStatus = (state, id, accountId, references, reblogOf) => {
+ if (reblogOf) {
+ // If we are deleting a reblog, just replace reblog with its original
+ return state.updateIn(['home', 'items'], list => list.map(item => item === id ? reblogOf : item));
+ }
+
// Remove references from timelines
['home', 'mentions', 'public', 'tag'].forEach(function (timeline) {
state = state.updateIn([timeline, 'items'], list => list.filterNot(item => item === id));
@@ -220,7 +225,7 @@ export default function timelines(state = initialState, action) {
case TIMELINE_UPDATE:
return updateTimeline(state, action.timeline, Immutable.fromJS(action.status), action.references);
case TIMELINE_DELETE:
- return deleteStatus(state, action.id, action.accountId, action.references);
+ return deleteStatus(state, action.id, action.accountId, action.references, action.reblogOf);
case CONTEXT_FETCH_SUCCESS:
return normalizeContext(state, action.id, Immutable.fromJS(action.ancestors), Immutable.fromJS(action.descendants));
case ACCOUNT_TIMELINE_FETCH_SUCCESS:
diff --git a/app/services/remove_status_service.rb b/app/services/remove_status_service.rb
index 836b8fdc59..7aca24d12d 100644
--- a/app/services/remove_status_service.rb
+++ b/app/services/remove_status_service.rb
@@ -53,7 +53,12 @@ class RemoveStatusService < BaseService
end
def unpush(type, receiver, status)
- redis.zremrangebyscore(FeedManager.instance.key(type, receiver.id), status.id, status.id)
+ if status.reblog?
+ redis.zadd(FeedManager.instance.key(type, receiver.id), status.reblog_of_id, status.reblog_of_id)
+ else
+ redis.zremrangebyscore(FeedManager.instance.key(type, receiver.id), status.id, status.id)
+ end
+
FeedManager.instance.broadcast(receiver.id, type: 'delete', id: status.id)
end
--
GitLab