From bc066d8936e2cfaa2dc275d9a5d4aefc0cbc1d86 Mon Sep 17 00:00:00 2001
From: Claire <claire.github-309c@sitedethib.com>
Date: Fri, 7 Jan 2022 19:50:12 +0100
Subject: [PATCH] Fix timeline streaming stopping for multiple sessions instead
of one (#17259)
* Fix timeline streaming stopping for multiple sessions instead of one
Fixes #17256.
In updating the code for a newer version of node-redis, #17183 also broke
redis subscription management when multiple streaming clients subscribe to the
same channel.
This commit restores the redis subscription management code.
* Let node-redis actually handle the subscriptions
---
streaming/index.js | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/streaming/index.js b/streaming/index.js
index 74cbf4c2c4..47f938b869 100644
--- a/streaming/index.js
+++ b/streaming/index.js
@@ -197,10 +197,12 @@ const startWorker = async (workerId) => {
/**
* @param {string} channel
+ * @param {function(string): void} callback
*/
- const unsubscribe = (channel) => {
+ const unsubscribe = (channel, callback) => {
+ log.silly(`Removing listener for ${channel}`);
- redisSubscribeClient.unsubscribe(channel);
+ redisSubscribeClient.unsubscribe(channel, callback);
};
const FALSE_VALUES = [
--
GitLab