From c8e4b9c66350e3a3f1b5fee6812f7e7eb97c0677 Mon Sep 17 00:00:00 2001
From: Eugen Rochko <eugen@zeonfederated.com>
Date: Fri, 20 Jan 2017 01:07:53 +0100
Subject: [PATCH] No loading bars for cards, no failure if it 404s (that's
expected)
---
.../javascripts/components/actions/cards.jsx | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/app/assets/javascripts/components/actions/cards.jsx b/app/assets/javascripts/components/actions/cards.jsx
index 808f1835b0..ee421d5d7c 100644
--- a/app/assets/javascripts/components/actions/cards.jsx
+++ b/app/assets/javascripts/components/actions/cards.jsx
@@ -11,6 +11,11 @@ export function fetchStatusCard(id) {
api(getState).get(`/api/v1/statuses/${id}/card`).then(response => {
dispatch(fetchStatusCardSuccess(id, response.data));
}).catch(error => {
+ if (error.response.status === 404) {
+ // This is fine
+ return;
+ }
+
dispatch(fetchStatusCardFail(id, error));
});
};
@@ -19,7 +24,8 @@ export function fetchStatusCard(id) {
export function fetchStatusCardRequest(id) {
return {
type: STATUS_CARD_FETCH_REQUEST,
- id
+ id,
+ skipLoading: true
};
};
@@ -27,7 +33,8 @@ export function fetchStatusCardSuccess(id, card) {
return {
type: STATUS_CARD_FETCH_SUCCESS,
id,
- card
+ card,
+ skipLoading: true
};
};
@@ -35,6 +42,7 @@ export function fetchStatusCardFail(id, error) {
return {
type: STATUS_CARD_FETCH_FAIL,
id,
- error
+ error,
+ skipLoading: true
};
};
--
GitLab