Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
mastodon
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Pierre Boudes
mastodon
Commits
43d754eb
Commit
43d754eb
authored
7 years ago
by
Eugen Rochko
Committed by
GitHub
7 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Fix not rejecting remote URIs when parsing out local IDs (#3012)
parent
2cc0d566
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
app/lib/tag_manager.rb
+1
-0
1 addition, 0 deletions
app/lib/tag_manager.rb
app/services/process_interaction_service.rb
+3
-1
3 additions, 1 deletion
app/services/process_interaction_service.rb
with
4 additions
and
1 deletion
app/lib/tag_manager.rb
+
1
−
0
View file @
43d754eb
...
...
@@ -48,6 +48,7 @@ class TagManager
end
def
unique_tag_to_local_id
(
tag
,
expected_type
)
return
nil
unless
local_id?
(
tag
)
matches
=
Regexp
.
new
(
"objectId=([
\\
d]+):objectType=
#{
expected_type
}
"
).
match
(
tag
)
return
matches
[
1
]
unless
matches
.
nil?
end
...
...
This diff is collapsed.
Click to expand it.
app/services/process_interaction_service.rb
+
3
−
1
View file @
43d754eb
...
...
@@ -123,7 +123,9 @@ class ProcessInteractionService < BaseService
end
def
status
(
xml
)
Status
.
find
(
TagManager
.
instance
.
unique_tag_to_local_id
(
activity_id
(
xml
),
'Status'
))
uri
=
activity_id
(
xml
)
return
nil
unless
TagManager
.
instance
.
local_id?
(
uri
)
Status
.
find
(
TagManager
.
instance
.
unique_tag_to_local_id
(
uri
,
'Status'
))
end
def
activity_id
(
xml
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment