Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
mastodon
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Pierre Boudes
mastodon
Commits
e34c5a35
Commit
e34c5a35
authored
7 years ago
by
unarist
Committed by
Eugen Rochko
7 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Fix 500 errors on searching invalid URLs (#3613)
parent
004672aa
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
app/services/fetch_remote_resource_service.rb
+1
-1
1 addition, 1 deletion
app/services/fetch_remote_resource_service.rb
spec/services/fetch_remote_resource_service_spec.rb
+1
-1
1 addition, 1 deletion
spec/services/fetch_remote_resource_service_spec.rb
with
2 additions
and
2 deletions
app/services/fetch_remote_resource_service.rb
+
1
−
1
View file @
e34c5a35
...
...
@@ -5,7 +5,7 @@ class FetchRemoteResourceService < BaseService
def
call
(
url
)
@url
=
url
process_url
unless
atom_
url
.
nil?
process_url
unless
fetched_
atom_
feed
.
nil?
end
private
...
...
This diff is collapsed.
Click to expand it.
spec/services/fetch_remote_resource_service_spec.rb
+
1
−
1
View file @
e34c5a35
...
...
@@ -10,7 +10,7 @@ describe FetchRemoteResourceService do
url
=
'http://example.com/missing-atom'
service
=
double
allow
(
FetchAtomService
).
to
receive
(
:new
).
and_return
service
allow
(
service
).
to
receive
(
:call
).
with
(
url
).
and_return
(
[
nil
,
'body'
]
)
allow
(
service
).
to
receive
(
:call
).
with
(
url
).
and_return
(
nil
)
result
=
subject
.
call
(
url
)
expect
(
result
).
to
be_nil
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment