-
- Downloads
Refactor and improve tests (#17386)
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
Showing
- spec/controllers/accounts_controller_spec.rb 1 addition, 1 deletionspec/controllers/accounts_controller_spec.rb
- spec/controllers/admin/accounts_controller_spec.rb 3 additions, 3 deletionsspec/controllers/admin/accounts_controller_spec.rb
- spec/controllers/admin/change_email_controller_spec.rb 5 additions, 7 deletionsspec/controllers/admin/change_email_controller_spec.rb
- spec/controllers/admin/confirmations_controller_spec.rb 4 additions, 6 deletionsspec/controllers/admin/confirmations_controller_spec.rb
- spec/controllers/admin/resets_controller_spec.rb 1 addition, 1 deletionspec/controllers/admin/resets_controller_spec.rb
- spec/controllers/api/base_controller_spec.rb 1 addition, 1 deletionspec/controllers/api/base_controller_spec.rb
- spec/controllers/api/v1/accounts/credentials_controller_spec.rb 1 addition, 1 deletion...ontrollers/api/v1/accounts/credentials_controller_spec.rb
- spec/controllers/api/v1/accounts/follower_accounts_controller_spec.rb 3 additions, 3 deletions...lers/api/v1/accounts/follower_accounts_controller_spec.rb
- spec/controllers/api/v1/accounts/following_accounts_controller_spec.rb 3 additions, 3 deletions...ers/api/v1/accounts/following_accounts_controller_spec.rb
- spec/controllers/api/v1/accounts/lists_controller_spec.rb 1 addition, 1 deletionspec/controllers/api/v1/accounts/lists_controller_spec.rb
- spec/controllers/api/v1/accounts/notes_controller_spec.rb 1 addition, 1 deletionspec/controllers/api/v1/accounts/notes_controller_spec.rb
- spec/controllers/api/v1/accounts/pins_controller_spec.rb 2 additions, 2 deletionsspec/controllers/api/v1/accounts/pins_controller_spec.rb
- spec/controllers/api/v1/accounts/relationships_controller_spec.rb 3 additions, 3 deletions...trollers/api/v1/accounts/relationships_controller_spec.rb
- spec/controllers/api/v1/accounts/search_controller_spec.rb 1 addition, 1 deletionspec/controllers/api/v1/accounts/search_controller_spec.rb
- spec/controllers/api/v1/accounts/statuses_controller_spec.rb 1 addition, 1 deletionspec/controllers/api/v1/accounts/statuses_controller_spec.rb
- spec/controllers/api/v1/accounts_controller_spec.rb 10 additions, 10 deletionsspec/controllers/api/v1/accounts_controller_spec.rb
- spec/controllers/api/v1/admin/account_actions_controller_spec.rb 2 additions, 2 deletions...ntrollers/api/v1/admin/account_actions_controller_spec.rb
- spec/controllers/api/v1/admin/accounts_controller_spec.rb 2 additions, 2 deletionsspec/controllers/api/v1/admin/accounts_controller_spec.rb
- spec/controllers/api/v1/admin/reports_controller_spec.rb 1 addition, 1 deletionspec/controllers/api/v1/admin/reports_controller_spec.rb
- spec/controllers/api/v1/blocks_controller_spec.rb 1 addition, 1 deletionspec/controllers/api/v1/blocks_controller_spec.rb
Loading
Please register or sign in to comment