Skip to content
Snippets Groups Projects
  1. Sep 20, 2017
    • mayaeh's avatar
      Add japanese translations for custom emoji. (#5007) · 33c39784
      mayaeh authored
      * Add japanese translations for custom emoji.
      
      * Remove spaces.
      
      * Change destroyed_msg.
      
      * Revert "Change destroyed_msg."
      33c39784
    • aschmitz's avatar
      Change IDs to strings rather than numbers in API JSON output (#5019) · 669fe9ee
      aschmitz authored
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Back out RelationshipsController Change
      
      This was made to make a test a bit less flakey, but has nothing to
      do with this branch.
      
      * Change internal streaming payloads to stringified IDs as well
      
      Per
      https://github.com/tootsuite/mastodon/pull/5019#issuecomment-330736452
      we need these changes to send deleted status IDs as strings, not
      integers.
      669fe9ee
    • Eugen Rochko's avatar
  2. Sep 19, 2017
  3. Sep 18, 2017
  4. Sep 17, 2017
  5. Sep 16, 2017
    • unarist's avatar
      ec36df97
    • Mingye Wang's avatar
      Minor Chinese check & jsx addition (#4973) · c8969dca
      Mingye Wang authored
      * zh-*: transition from "like" back to "fav"
      
      This commit reverts the translation for the yellow-star "fav" button
      back to "fav" in Chinese. Some ambuiguity between "like" and "fav" is
      deliberately used in zh-TW/HK by using the existing phrase "最爱"
      (favorite (adj.), lit. love-most) instead of "收藏" (favourite (v.),
      "collect") in some instances.
      
      Fixes #3511.
      
      * zh-*: apply suggestions for PR #4557
      
      * zh-cn: de-monetize ya account
      
      In Chinese two separate characters, 账 and 帐, can be used to spell the
      word for account (账/帐户). However, the one with a 贝 on the left is
      evolved from the latter specifically for monetary purposes. Since
      people usually can't figure out which one to use, it might be a good
      idea to use the original not-so-money one.
      
      * zh-*: complete jsx translation
      c8969dca
    • Lynx Kotoura's avatar
      Adjust landing pages 2 (#4967) · 1e3b1d72
      Lynx Kotoura authored
      * Adjust landing pages 2
      
      Fix styles of terms page
      Remove action buttons from timeline in about page
      Adjust styles of short description
      Adjust form inputs
      Set autocomplete off for username and email box in registration form. Remove line breakings.
      
      * Revert removing action buttons
      1e3b1d72
    • unarist's avatar
      Fix an error in ReplyDistributionWorker when replied status was deleted (#4974) · 0698c610
      unarist authored
      Reply distribution is proceed by Sidekiq, so replied status may be deleted before this.
      0698c610
Loading