Skip to content
Snippets Groups Projects
  1. Oct 14, 2021
  2. Oct 13, 2021
  3. Oct 09, 2021
  4. Oct 06, 2021
    • Claire's avatar
      Fix media attachment size validation not correctly accounting for file type (#16819) · 84ceebe1
      Claire authored
      * Fix media attachment size validation not correctly accounting for file type
      
      Fixes a regression introduced in #16724 caused by the fact that kt-paperclip
      now correctly runs validations before processing, meaning that file size
      verification could not rely on our before_post_processing hook.
      
      Moved the `before_post_processing` hooks to `before_validate` to make sure
      the media attachment type is set correctly before the file gets validated.
      
      * Add tests
      Unverified
      84ceebe1
  5. Sep 30, 2021
  6. Sep 29, 2021
    • Claire's avatar
      Switch from unmaintained paperclip to kt-paperclip (#16724) · fc3ae134
      Claire authored
      * Switch from unmaintained paperclip to kt-paperclip
      
      * Drop some compatibility monkey-patches not required by kt-paperclip
      
      * Drop media spoof check monkey-patching
      
      It's broken with kt-paperclip and hopefully it won't be needed anymore
      
      * Fix regression introduced by paperclip 6.1.0
      
      * Do not rely on pathname to call FastImage
      
      * Add test for ogg vorbis file with cover art
      
      * Add audio/vorbis to the accepted content-types
      
      This seems erroneous as this would be the content-type for a vorbis stream
      without an ogg container, but that's what the `marcel` gem outputs, so…
      
      * Restore missing for_as_default method
      
      * Refactor Attachmentable concern and delay Paperclip's content-type spoof check
      
      Check for content-type spoofing *after* setting the extension ourselves, this
      fixes a regression with kt-paperclip's validations being more strict than
      paperclip 6.0.0 and rejecting some Pleroma uploads because of unknown
      extensions.
      
      * Please CodeClimate
      
      * Add audio/vorbis to the unreliable set
      
      It doesn't correspond to a file format and thus has no extension associated.
      Unverified
      fc3ae134
Loading