Skip to content
Snippets Groups Projects
  1. Jun 02, 2021
    • Claire's avatar
      Fix account deletion sometimes failing because of optimistic locks (#16317) · 526332c5
      Claire authored
      * Fix account deletion sometimes failing because of optimistic locks
      
      In some rare occasions[1], deleting accounts would fail with a
      `StaleObjectError` exception.
      
      Indeed, account deletion manually sets the `AccountStat` values without
      handling cases where the optimistic locking on `AccountStat` would fail.
      
      To my knowledge, with the rewrite of account counters in #15913, the
      `DeleteAccountService` is now the only place that changes the counters in
      a way that is not atomic.
      
      Since in this specific case, we do not care about the previous values of the
      account counters, it appears we don't need locking at all for this table
      anymore.
      
      [1]: https://discourse.joinmastodon.org/t/account-cant-be-deleted/3602
      
      * Bump MAX_SUPPORTED_VERSION in maintenance script
      Unverified
      526332c5
  2. Jun 01, 2021
  3. May 31, 2021
  4. May 30, 2021
  5. May 29, 2021
  6. May 27, 2021
  7. May 25, 2021
  8. May 24, 2021
  9. May 22, 2021
Loading