Skip to content
Snippets Groups Projects
  1. Aug 28, 2020
    • Akihiko Odaki's avatar
      Introduce ApplicationController#cache_collection_paginated_by_id (#14677) · 64ef37b8
      Akihiko Odaki authored
      * Replace incorrect use of distinct with group
      
      Some uses of ActiveRecord::QueryMethods#distinct pass field names but they
      are incorrect for the current version of Rails.
      
      ActiveRecord::QueryMethods#group provides the expected behavior and
      benefits performance. See commit 6da24aad4cafdef8d8a2c92bac2002a5fc2fe9c8.
      
      * Introduce ApplicationController#cache_collection_paginated_by_id
      
      ApplicationController#cache_collection_paginated_by_id fuses
      ApplicationController#cache_collection and Paginable.paginate_by_id.
      
      An advantage of this method is that it prevents from modifying scope which
      Paginable.paginate_by_id may provide.
      ApplicationController#cache_collection always return an array and there
      is no possibility of the scope modification. It is also clear for a
      programmer, considering the implication of "cache".
      
      This method can also emit more efficient queries by using
      Cacheable.cache_ids before calling Paginable.paginate_by_id.
      Unverified
      64ef37b8
    • Akihiko Odaki's avatar
      Replace incorrect use of distinct with group (#14675) · e26e7a1c
      Akihiko Odaki authored
      Some uses of ActiveRecord::QueryMethods#distinct pass field names but they
      are incorrect for the current version of Rails.
      
      ActiveRecord::QueryMethods#group provides the expected behavior and
      benefits performance. See commit 6da24aad4cafdef8d8a2c92bac2002a5fc2fe9c8.
      Unverified
      e26e7a1c
  2. May 10, 2020
  3. Mar 06, 2020
  4. Sep 13, 2019
  5. Sep 28, 2018
    • Eugen Rochko's avatar
      Support min_id-based pagination in REST API (#8736) · f0fff3eb
      Eugen Rochko authored
      * Allow min_id pagination in Feed#get
      
      * Add min_id pagination to home and list timeline APIs
      
      * Add min_id pagination to account statuses, public and tag APIs
      
      * Remove unused stub in reports API
      
      * Use min_id pagination in notifications, favourites, and fix order
      
      * Fix HomeFeed#from_database not using paginate_by_id
      Unverified
      f0fff3eb
  6. Apr 02, 2018
  7. Mar 01, 2018
  8. Jul 07, 2017
  9. Jun 07, 2017
  10. May 31, 2017
  11. May 23, 2017
Loading