Skip to content
Snippets Groups Projects
  1. May 08, 2018
  2. May 02, 2018
    • Eugen Rochko's avatar
      Slightly reduce RAM usage (#7301) · cb5b5cb5
      Eugen Rochko authored
      * No need to re-require sidekiq plugins, they are required via Gemfile
      
      * Add derailed_benchmarks tool, no need to require TTY gems in Gemfile
      
      * Replace ruby-oembed with FetchOEmbedService
      
      Reduce startup by 45382 allocated objects
      
      * Remove preloaded JSON-LD in favour of caching HTTP responses
      
      Reduce boot RAM by about 6 MiB
      
      * Fix tests
      
      * Fix test suite by stubbing out JSON-LD contexts
      Unverified
      cb5b5cb5
    • Surinna Curtis's avatar
      Support Actors/Statuses with multiple types (#7305) · dc786c0c
      Surinna Curtis authored
      * Add equals_or_includes_any? helper in JsonLdHelper
      
      * Support arrays in JSON-LD type fields for actors/tags/objects.
      
      * Spec for resolving accounts with extension types
      
      * Style tweaks for codeclimate
      dc786c0c
  3. Apr 25, 2018
  4. Apr 23, 2018
  5. Apr 14, 2018
    • Eugen Rochko's avatar
      Add bio fields (#6645) · 78ed4ab7
      Eugen Rochko authored
      * Add bio fields
      
      - Fix #3211
      - Fix #232
      - Fix #121
      
      * Display bio fields in web UI
      
      * Fix output of links and missing fields
      
      * Federate bio fields over ActivityPub as PropertyValue
      
      * Improve how the fields are stored, add to Edit profile form
      
      * Add rel=me to links in fields
      
      Fix #121
      Unverified
      78ed4ab7
  6. Feb 28, 2018
  7. Feb 24, 2018
  8. Feb 18, 2018
  9. Feb 11, 2018
  10. Feb 10, 2018
  11. Feb 08, 2018
  12. Feb 07, 2018
  13. Jan 22, 2018
  14. Jan 18, 2018
    • Renato "Lond" Cerqueira's avatar
      When must_be_following_dm is on, only notify if recipient dm'ed user (#6283) · e56404be
      Renato "Lond" Cerqueira authored
      * When must_be_following_dm is on, only notify if recipient dm'ed user
      Currently, when must_be_following_dm is on, if a user sends a direct
      message replying to any status from the recipient, the recipient gets a
      notification. This should not be the case, as if the recipient posted
      something publicly this can be used to spam their notifications.
      
      * Refactor replied_to_status_is_direct_message?
      Following suggestion in PR
      e56404be
  15. Jan 17, 2018
  16. Jan 08, 2018
    • Eugen Rochko's avatar
      Fix bad URL schemes being accepted (#6219) · e4a241ab
      Eugen Rochko authored
      * Fix actors accepting invalid URI schemes or different host between URI and URL
      
      * Fix statuses accepting invalid URI scheme or different host to actor
      
      * Adjust tests to new requirements
      
      * Improve readability of mismatching_origin?/invalid_origin? methods
      Unverified
      e4a241ab
  17. Dec 06, 2017
  18. Dec 05, 2017
    • Eugen Rochko's avatar
      Add list of lists component to web UI (#5811) · e20895f2
      Eugen Rochko authored
      * Add list of lists component to web UI
      
      * Add list adding
      
      * Add list removing
      
      * List editor modal
      
      * Add API account search limited by following=true relation
      
      * Rework list editor modal
      
      * Remove mandatory pagination of GET /api/v1/lists/:id/accounts
      
      * Adjust search input placeholder
      
      * Fix rspec (#5890)
      
      * i18n: (zh-CN) Add missing translations for #5811 (#5891)
      
      * i18n: (zh-CN) yarn manage:translations -- zh-CN
      
      * i18n: (zh-CN) Add missing translations for #5811
      
      * Fix some issues
      
      - Display loading/missing state for list timelines
      - Order lists alphabetically in overview
      - Fix async list editor reset
      - Redirect to /lists after deleting unpinned list
      - Redirect to / after pinning a list
      
      * Remove dead list columns when a list is deleted or fetch returns 404
      Unverified
      e20895f2
  19. Nov 30, 2017
  20. Nov 28, 2017
    • aschmitz's avatar
      Allow hiding of reblogs from followed users (#5762) · eeaec398
      aschmitz authored
      * Allow hiding of reblogs from followed users
      
      This adds a new entry to the account menu to allow users to hide
      future reblogs from a user (and then if they've done that, to show
      future reblogs instead).
      
      This does not remove or add historical reblogs from/to the user's
      timeline; it only affects new statuses.
      
      The API for this operates by sending a "reblogs" key to the follow
      endpoint. If this is sent when starting a new follow, it will be
      respected from the beginning of the follow relationship (even if
      the follow request must be approved by the followee). If this is
      sent when a follow relationship already exists, it will simply
      update the existing follow relationship. As with the notification
      muting, this will now return an object ({reblogs: [true|false]}) or
      false for each follow relationship when requesting relationship
      information for an account. This should cause few issues due to an
      object being truthy in many languages, but some modifications may
      need to be made in pickier languages.
      
      Database changes: adds a show_reblogs column (default true,
      non-nullable) to the follows and follow_requests tables. Because
      these are non-nullable, we use the existing MigrationHelpers to
      perform this change without locking those tables, although the
      tables are likely to be small anyway.
      
      Tests included.
      
      See also <https://github.com/glitch-soc/mastodon/pull/212>.
      
      * Rubocop fixes
      
      * Code review changes
      
      * Test fixes
      
      This patchset closes #648 and resolves #3271.
      
      * Rubocop fix
      
      * Revert reblogs defaulting in argument, fix tests
      
      It turns out we needed this for the same reason we needed it in muting:
      if nil gets passed in somehow (most usually by an API client not passing
      any value), we need to detect and handle it.
      
      We could specify a default in the parameter and then also catch nil, but
      there's no great reason to duplicate the default value.
      eeaec398
    • ThibG's avatar
      Fix handling of temporary failures in ProcessMentionsService (#5842) · b8efb5da
      ThibG authored
      * Add test for temporary account resolving failures in ProcessMentionsService
      
      * Fix processing of mentions to already-known remote accounts on temporary failures
      b8efb5da
  21. Nov 17, 2017
    • Eugen Rochko's avatar
      Lists (#5703) · 24cafd73
      Eugen Rochko authored
      * Add structure for lists
      
      * Add list timeline streaming API
      
      * Add list APIs, bind list-account relation to follow relation
      
      * Add API for adding/removing accounts from lists
      
      * Add pagination to lists API
      
      * Add pagination to list accounts API
      
      * Adjust scopes for new APIs
      
      - Creating and modifying lists merely requires "write" scope
      - Fetching information about lists merely requires "read" scope
      
      * Add test for wrong user context on list timeline
      
      * Clean up tests
      Unverified
      24cafd73
    • ysksn's avatar
      Remove empty strings (#5732) · 9dd5e329
      ysksn authored
      9dd5e329
  22. Nov 15, 2017
    • Surinna Curtis's avatar
      Optional notification muting (#5087) · 031a5a8f
      Surinna Curtis authored
      * Add a hide_notifications column to mutes
      
      * Add muting_notifications? and a notifications argument to mute!
      
      * block notifications in notify_service from hard muted accounts
      
      * Add specs for how mute! interacts with muting_notifications?
      
      * specs testing that hide_notifications in mutes actually hides notifications
      
      * Add support for muting notifications in MuteService
      
      * API support for muting notifications (and specs)
      
      * Less gross passing of notifications flag
      
      * Break out a separate mute modal with a hide-notifications checkbox.
      
      * Convert profile header mute to use mute modal
      
      * Satisfy eslint.
      
      * specs for MuteService notifications params
      
      * add trailing newlines to files for Pork :)
      
      * Put the label for the hide notifications checkbox in a label element.
      
      * Add a /api/v1/mutes/details route that just returns the array of mutes.
      
      * Define a serializer for /api/v1/mutes/details
      
      * Add more specs for the /api/v1/mutes/details endpoint
      
      * Expose whether a mute hides notifications in the api/v1/relationships endpoint
      
      * Show whether muted users' notifications are muted in account lists
      
      * Allow modifying the hide_notifications of a mute with the /api/v1/accounts/:id/mute endpoint
      
      * make the hide/unhide notifications buttons work
      
      * satisfy eslint
      
      * In probably dead code, replace a dispatch of muteAccount that was skipping the modal with launching the mute modal.
      
      * fix a missing import
      
      * add an explanatory comment to AccountInteractions
      
      * Refactor handling of default params for muting to make code cleaner
      
      * minor code style fixes oops
      
      * Fixed a typo that was breaking the account mute API endpoint
      
      * Apply white-space: nowrap to account relationships icons
      
      * Fix code style issues
      
      * Remove superfluous blank line
      
      * Rename /api/v1/mutes/details -> /api/v2/mutes
      
      * Don't serialize "account" in MuteSerializer
      
      Doing so is somewhat unnecessary since it's always the current user's account.
      
      * Fix wrong variable name in api/v2/mutes
      
      * Use Toggle in place of checkbox in the mute modal.
      
      * Make the Toggle in the mute modal look better
      
      * Code style changes in specs and removed an extra space
      
      * Code review suggestions from akihikodaki
      
      Also fixed a syntax error in tests for AccountInteractions.
      
      * Make AddHideNotificationsToMute Concurrent
      
      It's not clear how much this will benefit instances in practice, as the
      number of mutes tends to be pretty small, but this should prevent any
      blocking migrations nonetheless.
      
      * Fix up migration things
      
      * Remove /api/v2/mutes
      031a5a8f
  23. Nov 14, 2017
  24. Oct 13, 2017
    • Lex Alexander's avatar
      Retoot count increases without reason (#5363) · b8bae966
      Lex Alexander authored
      * Retoot count increases without reason
      
      -The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice.
      -This calls it when the transaction is finished by using after_create_commit.
      -Fixes #4916.
      
      * Added test case for after_create_commit callback for checking reblog count.
      
      * Rewrote test to keep original, but added one for only the after_create_commit callback.
      b8bae966
  25. Oct 08, 2017
  26. Oct 04, 2017
    • ThibG's avatar
      Fix regression in FetchRemoteResourceService (#5217) · 2559d916
      ThibG authored
      * Fix regression in FetchRemoteResourceService
      
      * Update specs to match interface changes made in #5114
      2559d916
    • aschmitz's avatar
      Non-Serial ("Snowflake") IDs (#4801) · 468523f4
      aschmitz authored
      * Use non-serial IDs
      
      This change makes a number of nontrivial tweaks to the data model in
      Mastodon:
      
      * All IDs are now 8 byte integers (rather than mixed 4- and 8-byte)
      * IDs are now assigned as:
        * Top 6 bytes: millisecond-resolution time from epoch
        * Bottom 2 bytes: serial (within the millisecond) sequence number
        * See /lib/tasks/db.rake's `define_timestamp_id` for details, but
          note that the purpose of these changes is to make it difficult to
          determine the number of objects in a table from the ID of any
          object.
      * The Redis sorted set used for the feed will have values used to look
        up toots, rather than scores. This is almost always the same as the
        existing behavior, except in the case of boosted toots. This change
        was made because Redis stores scores as double-precision floats,
        which cannot store the new ID format exactly. Note that this doesn't
        cause problems with sorting/pagination, because ZREVRANGEBYSCORE
        sorts lexicographically when scores are tied. (This will still cause
        sorting issues when the ID gains a new significant digit, but that's
        extraordinarily uncommon.)
      
      Note a couple of tradeoffs have been made in this commit:
      
      * lib/tasks/db.rake is used to enforce many/most column constraints,
        because this commit seems likely to take a while to bring upstream.
        Enforcing a post-migrate hook is an easier way to maintain the code
        in the interim.
      * Boosted toots will appear in the timeline as many times as they have
        been boosted. This is a tradeoff due to the way the feed is saved in
        Redis at the moment, but will be handled by a future commit.
      
      This would effectively close Mastodon's #1059, as it is a
      snowflake-like system of generating IDs. However, given how involved
      the changes were simply within Mastodon, it may have unexpected
      interactions with some clients, if they store IDs as doubles
      (or as 4-byte integers). This was a problem that Twitter ran into with
      their "snowflake" transition, particularly in JavaScript clients that
      treated IDs as JS integers, rather than strings. It therefore would be
      useful to test these changes at least in the web interface and popular
      clients before pushing them to all users.
      
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Restructure feed pushes/unpushes
      
      This was necessary because the previous behavior used Redis zset scores
      to identify statuses, but those are IEEE double-precision floats, so we
      can't actually use them to identify all 64-bit IDs. However, it leaves
      the code in a much better state for refactoring reblog handling /
      coalescing.
      
      Feed-management code has been consolidated in FeedManager, including:
      
      * BatchedRemoveStatusService no longer directly manipulates feed zsets
      * RemoveStatusService no longer directly manipulates feed zsets
      * PrecomputeFeedService has moved its logic to FeedManager#populate_feed
      
      (PrecomputeFeedService largely made lots of calls to FeedManager, but
      didn't follow the normal adding-to-feed process.)
      
      This has the effect of unifying all of the feed push/unpush logic in
      FeedManager, making it much more tractable to update it in the future.
      
      Due to some additional checks that must be made during, for example,
      batch status removals, some Redis pipelining has been removed. It does
      not appear that this should cause significantly increased load, but if
      necessary, some optimizations are possible in batch cases. These were
      omitted in the pursuit of simplicity, but a batch_push and batch_unpush
      would be possible in the future.
      
      Tests were added to verify that pushes happen under expected conditions,
      and to verify reblog behavior (both on pushing and unpushing). In the
      case of unpushing, this includes testing behavior that currently leads
      to confusion such as Mastodon's #2817, but this codifies that the
      behavior is currently expected.
      
      * Rubocop fixes
      
      I could swear I made these changes already, but I must have lost them
      somewhere along the line.
      
      * Address review comments
      
      This addresses the first two comments from review of this feature:
      
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336735
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336931
      
      This adds an optional argument to FeedManager#key, the subtype of feed
      key to generate. It also tests to ensure that FeedManager's settings are
      such that reblogs won't be tracked forever.
      
      * Hardcode IdToBigints migration columns
      
      This addresses a comment during review:
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139337452
      
      This means we'll need to make sure that all _id columns going forward
      are bigints, but that should happen automatically in most cases.
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Only implement timestamp IDs for Status IDs
      
      Per discussion in #4801, this is only being merged in for Status IDs at
      this point. We do this in a migration, as there is no longer use for
      a post-migration hook. We keep the initialization of the timestamp_id
      function as a Rake task, as it is also needed after db:schema:load (as
      db/schema.rb doesn't store Postgres functions).
      
      * Change internal streaming payloads to stringified IDs as well
      
      This is equivalent to 591a9af356faf2d5c7e66e3ec715502796c875cd from
      #5019, with an extra change for the addition to FeedManager#unpush.
      
      * Ensure we have a status_id_seq sequence
      
      Apparently this is not a given when specifying a custom ID function,
      so now we ensure it gets created. This uses the generic version of this
      function to more easily support adding additional tables with timestamp
      IDs in the future, although it would be possible to cut this down to a
      less generic version if necessary. It is only run during db:schema:load
      or the relevant migration, so the overhead is extraordinarily minimal.
      
      * Transition reblogs to new Redis format
      
      This provides a one-way migration to transition old Redis reblog entries
      into the new format, with a separate tracking entry for reblogs.
      
      It is not invertible because doing so could (if timestamp IDs are used)
      require a database query for each status in each users' feed, which is
      likely to be a significant toll on major instances.
      
      * Address review comments from @akihikodaki
      
      No functional changes.
      
      * Additional review changes
      
      * Heredoc cleanup
      
      * Run db:schema:load hooks for test in development
      
      This matches the behavior in Rails'
      ActiveRecord::Tasks::DatabaseTasks.each_current_configuration, which
      would otherwise break `rake db:setup` in development.
      
      It also moves some functionality out to a library, which will be a good
      place to put additional related functionality in the near future.
      468523f4
  27. Oct 03, 2017
    • Akihiko Odaki's avatar
      Validate id of ActivityPub representations (#5114) · 63f09797
      Akihiko Odaki authored
      Additionally, ActivityPub::FetchRemoteStatusService no longer parses
      activities.
      OStatus::Activity::Creation no longer delegates to ActivityPub because
      the provided ActivityPub representations are not signed while OStatus
      representations are.
      63f09797
  28. Sep 25, 2017
  29. Sep 19, 2017
  30. Sep 17, 2017
  31. Sep 16, 2017
  32. Sep 14, 2017
  33. Sep 10, 2017
    • Eugen Rochko's avatar
      Default follows for new users (#4871) · 7d7844a4
      Eugen Rochko authored
      When a new user confirms their e-mail, bootstrap their home timeline
      by automatically following a set of accounts. By default, all local
      admin accounts (that are unlocked). Can be customized by new admin
      setting (comma-separated usernames, local and unlocked only)
      7d7844a4
  34. Sep 09, 2017
Loading