Skip to content
Snippets Groups Projects
  1. Jun 02, 2023
  2. May 31, 2023
  3. May 23, 2023
  4. May 09, 2023
  5. May 04, 2023
  6. May 02, 2023
  7. Apr 26, 2023
  8. Mar 31, 2023
  9. Mar 30, 2023
  10. Mar 23, 2023
  11. Mar 17, 2023
  12. Mar 16, 2023
  13. Mar 10, 2023
  14. Mar 04, 2023
  15. Mar 03, 2023
  16. Feb 20, 2023
  17. Feb 18, 2023
  18. Feb 16, 2023
  19. Dec 16, 2022
  20. Dec 15, 2022
    • Kaspar V's avatar
      linting: RuboCop update, config fixes (#20574) · 19f78ea8
      Kaspar V authored
      * fix(rubocop): update gems and add performance and rspec
      
      fix(rubocop): update gems and add performance and rspec
      
      - update present rubocop gems
      - add rubocop-rspec and rubocop-performance gems
      - move rubocop gems to gem group :development, :test in order to
        make linting in a github action that runs with RAILS_ENV=test possible
      
      * feat(rubocop): disable some annoyance RSpec cops
      
      To mee these prooved to be more annoying than helpful.
      If not agreed, they can be enabled any time.
      
      * fix(rubocop): do not ignore spec/**/*
      
      Because rubocop-rspec should lint the specs as well, and they
      deserve to be readable in general. It is relevant code, after all.
      
      * fix(rubocop): change ignore db/**/* to db/schema.rb
      
      because rails cops do some lints for migrations.
      E.g. reversable migrations linting and more.
      
      * fix(rubocop): tune rules configs
      
      Bunch of commits squashed:
      
      fix(rubocop): enable Layout/LineLength cop
      
      Because this project has code with line lenghts > 500 chars.
      This is not good practice at all, so I strongly suggest to
      change the practice in the future.
      
      But allow heredoc, URI and comments to still be long lines
      and make the default Max: 120 explicit, by repeating it in the
      config. To me this max length seems reasonable. Perhaps
      a bit more could be ok for some. But > 500 chars in one line
      Seems to be way too long IMHO.
      
      fix(rubocop): Metrics/CyclomaticComplexity Max to 12
      
      The default is 7, perhaps quite strict. But 25 is too loose,
      the rule becomes pointless like that.
      
      fix(rubocop): AllCops ruby version, cacheing and more info
      
      - fix the target ruby version from 2.5 to 3.0
      - have the cop error messages to be more informative and helpful
      - enable cacheing in /tmp
      
      fix(rubocop): Metrics/AbcSize to 34 from 115
      
      Rubocops default is 17. If the rule is at 115 is becomes
      pointless.
      
      fix(rubocop): Metrics/BlockLength improvements
      
      - instead of ignoring tasks completely, ignore only the
        long blocks that are specific to tasks (task, namespace)
      - ignore also concern specific block methods (included, class_methods)
      
      fix(rubocop): Metrics/ClassLength count heredoc array as one line
      
      fix(rubocop): Metrics/MethodLength Max to 25
      
      - the default is 10, but 65 is too loose, so perhaps 25?
      
      fix(rubocop): Metrics/ModuleLength array and heredoc count as one
      
      fix(rubocop): Metrics/PerceivedComplexity to 16 from 25
      
      Rubocops default is 8, so how about only doubling that, instead
      of > than tripple it?
      
      fix(rubocop): enable Style/RedundantAssignment
      
      Because I think that this rule would never really hurt,
      but improve code quality and readability.
      
      fix(rubocop): enable Style/RescueStandardError
      
      I think everyone that ever had to debug what this can bring
      will hopefully agree that this rule totally makes sense.
      In the super rare exeptions where this is totally needed,
      it can be excluded by disabling comment in that place.
      
      fix(rubocop): Metrics/ParameterLists add explicit defaults and some excludes
      19f78ea8
  21. Nov 27, 2022
  22. Nov 17, 2022
  23. Jul 05, 2022
  24. Jun 09, 2022
    • Eugen Rochko's avatar
      Change brand color and logotypes (#18592) · 45aa5781
      Eugen Rochko authored
      - Add rake task for generating Apple/Android icons and favicons from SVG
      - Add rake task for generating PNG icons and logos for e-mails from SVG
      - Remove obsolete Microsoft icons and configuration
      - Remove PWA shortcut icons
      45aa5781
  25. Mar 21, 2022
  26. Mar 12, 2022
    • Claire's avatar
      Update fix-duplicates maintenance task (#17731) · 642528f4
      Claire authored
      * Update fix-duplicates task to 2022_02_10_153119
      
      Also add support for Appeal to AccountMerging#merge_with!
      
      * Update fix-duplicates task to 2022_03_07_094650
      
      * Update fix-duplicates task to 2022_03_09_213005
      
      * Update fix-duplicates task to 2022_03_07_083603
      
      * Update fix-duplicates task to 2022_03_10_060626
      
      * Update fix-duplicates script to 2022_03_07_083603
      
      * Update fix-duplicates task to 2022_03_10_060706
      
      * Update fix-duplicates task to 2022_03_10_060959
      
      * Silence CodeClimate
      642528f4
  27. Feb 24, 2022
    • Eugen Rochko's avatar
      Add trending statuses (#17431) · 27965ce5
      Eugen Rochko authored
      * Add trending statuses
      
      * Fix dangling items with stale scores in localized sets
      
      * Various fixes and improvements
      
      - Change approve_all/reject_all to approve_accounts/reject_accounts
      - Change Trends::Query methods to not mutate the original query
      - Change Trends::Query#skip to offset
      - Change follow recommendations to be refreshed in a transaction
      
      * Add tests for trending statuses filtering behaviour
      
      * Fix not applying filtering scope in controller
      27965ce5
  28. Jan 07, 2021
    • abcang's avatar
      Fix rubocop config and warnings (#15503) · efffdd37
      abcang authored
      * disable NewCops
      
      * update TargetRubyVersion
      
      * Fix Lint/MissingSuper for ActiveModelSerializers::Model
      
      * Fix Lint/MissingSuper for feed
      
      * Fix Lint/FloatComparison
      
      * Do not use instance variables
      efffdd37
  29. Sep 01, 2020
  30. Jul 14, 2020
  31. May 10, 2020
  32. Dec 02, 2019
Loading