Skip to content
Snippets Groups Projects
  1. Nov 15, 2017
    • ysksn's avatar
      Add a test for Tag#to_param (#5705) · 7d7df877
      ysksn authored
      7d7df877
    • Surinna Curtis's avatar
      Optional notification muting (#5087) · 031a5a8f
      Surinna Curtis authored
      * Add a hide_notifications column to mutes
      
      * Add muting_notifications? and a notifications argument to mute!
      
      * block notifications in notify_service from hard muted accounts
      
      * Add specs for how mute! interacts with muting_notifications?
      
      * specs testing that hide_notifications in mutes actually hides notifications
      
      * Add support for muting notifications in MuteService
      
      * API support for muting notifications (and specs)
      
      * Less gross passing of notifications flag
      
      * Break out a separate mute modal with a hide-notifications checkbox.
      
      * Convert profile header mute to use mute modal
      
      * Satisfy eslint.
      
      * specs for MuteService notifications params
      
      * add trailing newlines to files for Pork :)
      
      * Put the label for the hide notifications checkbox in a label element.
      
      * Add a /api/v1/mutes/details route that just returns the array of mutes.
      
      * Define a serializer for /api/v1/mutes/details
      
      * Add more specs for the /api/v1/mutes/details endpoint
      
      * Expose whether a mute hides notifications in the api/v1/relationships endpoint
      
      * Show whether muted users' notifications are muted in account lists
      
      * Allow modifying the hide_notifications of a mute with the /api/v1/accounts/:id/mute endpoint
      
      * make the hide/unhide notifications buttons work
      
      * satisfy eslint
      
      * In probably dead code, replace a dispatch of muteAccount that was skipping the modal with launching the mute modal.
      
      * fix a missing import
      
      * add an explanatory comment to AccountInteractions
      
      * Refactor handling of default params for muting to make code cleaner
      
      * minor code style fixes oops
      
      * Fixed a typo that was breaking the account mute API endpoint
      
      * Apply white-space: nowrap to account relationships icons
      
      * Fix code style issues
      
      * Remove superfluous blank line
      
      * Rename /api/v1/mutes/details -> /api/v2/mutes
      
      * Don't serialize "account" in MuteSerializer
      
      Doing so is somewhat unnecessary since it's always the current user's account.
      
      * Fix wrong variable name in api/v2/mutes
      
      * Use Toggle in place of checkbox in the mute modal.
      
      * Make the Toggle in the mute modal look better
      
      * Code style changes in specs and removed an extra space
      
      * Code review suggestions from akihikodaki
      
      Also fixed a syntax error in tests for AccountInteractions.
      
      * Make AddHideNotificationsToMute Concurrent
      
      It's not clear how much this will benefit instances in practice, as the
      number of mutes tends to be pretty small, but this should prevent any
      blocking migrations nonetheless.
      
      * Fix up migration things
      
      * Remove /api/v2/mutes
      031a5a8f
    • ysksn's avatar
      Add tests for StreamEntry (#5687) · 6d7e05ec
      ysksn authored
      * Add tests for StreamEntry
      
      - `#object_type`
      - `#verb`
      - `#mentions`
      
      * Fix to test results instead of implementations
      6d7e05ec
  2. Nov 14, 2017
  3. Nov 13, 2017
  4. Nov 12, 2017
  5. Nov 10, 2017
    • ysksn's avatar
      Add tests for RemoteFollow (#5651) · 56720ba5
      ysksn authored
      * Add tests for RemoteFollow.initialize
      
      * Add tests for RemoteFollow#valid?
      
      * Add tests for RemoteFollow#subscribe_address_for
      56720ba5
  6. Nov 09, 2017
    • ysksn's avatar
      Add tests for Notification (#5640) · 07cca6e3
      ysksn authored
      * Add tests for Notification#target_status
      
      * Add tests for Notification#browserable?
      
      * Add tests for Notification.reload_stale_associations!
      07cca6e3
    • ysksn's avatar
      Add and Remove tests for FollowRequest (#5622) · 54b42901
      ysksn authored
      * Add a test for FollowRequest#authorize!
      
      * Remove tests
      
      There is no need to test
      ActiveModel::Validations::ClassMethods#validates.
      
      * Make an alias of destroy! as reject!
      
      Instead of defining the method,
      make an alias of destroy! as reject! because of reducing test.
      54b42901
    • Nanamachi's avatar
      Rewrite account_controller_spec (#5633) · d200e041
      Nanamachi authored
      * make accounts_controller_spec DRY
      
      * Add blocked user spec
      d200e041
  7. Nov 08, 2017
  8. Nov 06, 2017
  9. Nov 05, 2017
  10. Oct 26, 2017
  11. Oct 17, 2017
    • aschmitz's avatar
      Clean up reblog tracking keys, related improvements (#5428) · 554c2fd8
      aschmitz authored
      * Clean up reblog-tracking sets from FeedManager
      
      Builds on #5419, with a few minor optimizations and cleanup of sets
      after they are no longer needed.
      
      * Update tests, fix multiply-reblogged case
      
      Previously, we would have lost the fact that a given status was
      reblogged if the displayed reblog of it was removed, now we don't.
      
      Also added tests to make sure FeedManager#trim cleans up our reblog
      tracking keys, fixed up FeedCleanupScheduler to use the right loop,
      and fixed the test for it.
      554c2fd8
  12. Oct 16, 2017
    • Eugen Rochko's avatar
      Keep references to all reblogs of a status on home feed (#5419) · 34118169
      Eugen Rochko authored
      * Keep references to all reblogs of a status on home feed
      
      When inserting reblog: Add to set of reblogs of this status on
      the feed, if original status was present in the feed, add it to
      that set as well.
      
      When removing a reblog: Remove it from that set. Take random
      remaining item from the set. If one exists, re-insert it into feed,
      otherwise do not re-insert anything.
      
      Fix #4210
      
      * When original is removed, toss out reblog references
      34118169
    • unarist's avatar
      Fix un-reblogged status being at wrong position in the home timeline (#5418) · 6f490b4b
      unarist authored
      We've changed un-reblogging behavior when we implement Snowflake, to insert un-reblogged status at the position reblogging status existed.
      
      However, our API expects home timeline is ordered by status ids, and max_id/since_id filters by zset score. Due to this, un-reblogged status appears as a last item of result set, and timeline expansion may skips many statuses.
      
      So this reverts that change...reblogged status inserted at corresponding position to its id.
      6f490b4b
    • Yamagishi Kazutoshi's avatar
  13. Oct 14, 2017
  14. Oct 13, 2017
    • Eugen Rochko's avatar
      3283868e
    • Lex Alexander's avatar
      Retoot count increases without reason (#5363) · b8bae966
      Lex Alexander authored
      * Retoot count increases without reason
      
      -The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice.
      -This calls it when the transaction is finished by using after_create_commit.
      -Fixes #4916.
      
      * Added test case for after_create_commit callback for checking reblog count.
      
      * Rewrote test to keep original, but added one for only the after_create_commit callback.
      b8bae966
  15. Oct 09, 2017
  16. Oct 08, 2017
  17. Oct 07, 2017
  18. Oct 06, 2017
  19. Oct 04, 2017
    • ThibG's avatar
      Fix regression in FetchRemoteResourceService (#5217) · 2559d916
      ThibG authored
      * Fix regression in FetchRemoteResourceService
      
      * Update specs to match interface changes made in #5114
      2559d916
    • utam0k's avatar
      Implement EmailBlackList (#5109) · b3af3f9f
      utam0k authored
      * Implement BlacklistedEmailDomain
      
      * Use Faker::Internet.domain_name
      
      * Remove note column
      
      * Add frozen_string_literal comment
      
      * Delete unnecessary codes
      
      * Sort alphabetically
      
      * Change of wording
      
      * Rename BlacklistedEmailDomain to EmailDomainBlock
      b3af3f9f
    • Yamagishi Kazutoshi's avatar
      Separate notifications preferences from general preferences (#4447) · 178f718a
      Yamagishi Kazutoshi authored
      * Separate notifications preferences from general preferences
      
      * Refine settings/notifications/show
      
      * remove preferences.notifications
      178f718a
    • aschmitz's avatar
      Non-Serial ("Snowflake") IDs (#4801) · 468523f4
      aschmitz authored
      * Use non-serial IDs
      
      This change makes a number of nontrivial tweaks to the data model in
      Mastodon:
      
      * All IDs are now 8 byte integers (rather than mixed 4- and 8-byte)
      * IDs are now assigned as:
        * Top 6 bytes: millisecond-resolution time from epoch
        * Bottom 2 bytes: serial (within the millisecond) sequence number
        * See /lib/tasks/db.rake's `define_timestamp_id` for details, but
          note that the purpose of these changes is to make it difficult to
          determine the number of objects in a table from the ID of any
          object.
      * The Redis sorted set used for the feed will have values used to look
        up toots, rather than scores. This is almost always the same as the
        existing behavior, except in the case of boosted toots. This change
        was made because Redis stores scores as double-precision floats,
        which cannot store the new ID format exactly. Note that this doesn't
        cause problems with sorting/pagination, because ZREVRANGEBYSCORE
        sorts lexicographically when scores are tied. (This will still cause
        sorting issues when the ID gains a new significant digit, but that's
        extraordinarily uncommon.)
      
      Note a couple of tradeoffs have been made in this commit:
      
      * lib/tasks/db.rake is used to enforce many/most column constraints,
        because this commit seems likely to take a while to bring upstream.
        Enforcing a post-migrate hook is an easier way to maintain the code
        in the interim.
      * Boosted toots will appear in the timeline as many times as they have
        been boosted. This is a tradeoff due to the way the feed is saved in
        Redis at the moment, but will be handled by a future commit.
      
      This would effectively close Mastodon's #1059, as it is a
      snowflake-like system of generating IDs. However, given how involved
      the changes were simply within Mastodon, it may have unexpected
      interactions with some clients, if they store IDs as doubles
      (or as 4-byte integers). This was a problem that Twitter ran into with
      their "snowflake" transition, particularly in JavaScript clients that
      treated IDs as JS integers, rather than strings. It therefore would be
      useful to test these changes at least in the web interface and popular
      clients before pushing them to all users.
      
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Restructure feed pushes/unpushes
      
      This was necessary because the previous behavior used Redis zset scores
      to identify statuses, but those are IEEE double-precision floats, so we
      can't actually use them to identify all 64-bit IDs. However, it leaves
      the code in a much better state for refactoring reblog handling /
      coalescing.
      
      Feed-management code has been consolidated in FeedManager, including:
      
      * BatchedRemoveStatusService no longer directly manipulates feed zsets
      * RemoveStatusService no longer directly manipulates feed zsets
      * PrecomputeFeedService has moved its logic to FeedManager#populate_feed
      
      (PrecomputeFeedService largely made lots of calls to FeedManager, but
      didn't follow the normal adding-to-feed process.)
      
      This has the effect of unifying all of the feed push/unpush logic in
      FeedManager, making it much more tractable to update it in the future.
      
      Due to some additional checks that must be made during, for example,
      batch status removals, some Redis pipelining has been removed. It does
      not appear that this should cause significantly increased load, but if
      necessary, some optimizations are possible in batch cases. These were
      omitted in the pursuit of simplicity, but a batch_push and batch_unpush
      would be possible in the future.
      
      Tests were added to verify that pushes happen under expected conditions,
      and to verify reblog behavior (both on pushing and unpushing). In the
      case of unpushing, this includes testing behavior that currently leads
      to confusion such as Mastodon's #2817, but this codifies that the
      behavior is currently expected.
      
      * Rubocop fixes
      
      I could swear I made these changes already, but I must have lost them
      somewhere along the line.
      
      * Address review comments
      
      This addresses the first two comments from review of this feature:
      
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336735
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336931
      
      This adds an optional argument to FeedManager#key, the subtype of feed
      key to generate. It also tests to ensure that FeedManager's settings are
      such that reblogs won't be tracked forever.
      
      * Hardcode IdToBigints migration columns
      
      This addresses a comment during review:
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139337452
      
      This means we'll need to make sure that all _id columns going forward
      are bigints, but that should happen automatically in most cases.
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Only implement timestamp IDs for Status IDs
      
      Per discussion in #4801, this is only being merged in for Status IDs at
      this point. We do this in a migration, as there is no longer use for
      a post-migration hook. We keep the initialization of the timestamp_id
      function as a Rake task, as it is also needed after db:schema:load (as
      db/schema.rb doesn't store Postgres functions).
      
      * Change internal streaming payloads to stringified IDs as well
      
      This is equivalent to 591a9af356faf2d5c7e66e3ec715502796c875cd from
      #5019, with an extra change for the addition to FeedManager#unpush.
      
      * Ensure we have a status_id_seq sequence
      
      Apparently this is not a given when specifying a custom ID function,
      so now we ensure it gets created. This uses the generic version of this
      function to more easily support adding additional tables with timestamp
      IDs in the future, although it would be possible to cut this down to a
      less generic version if necessary. It is only run during db:schema:load
      or the relevant migration, so the overhead is extraordinarily minimal.
      
      * Transition reblogs to new Redis format
      
      This provides a one-way migration to transition old Redis reblog entries
      into the new format, with a separate tracking entry for reblogs.
      
      It is not invertible because doing so could (if timestamp IDs are used)
      require a database query for each status in each users' feed, which is
      likely to be a significant toll on major instances.
      
      * Address review comments from @akihikodaki
      
      No functional changes.
      
      * Additional review changes
      
      * Heredoc cleanup
      
      * Run db:schema:load hooks for test in development
      
      This matches the behavior in Rails'
      ActiveRecord::Tasks::DatabaseTasks.each_current_configuration, which
      would otherwise break `rake db:setup` in development.
      
      It also moves some functionality out to a library, which will be a good
      place to put additional related functionality in the near future.
      468523f4
  20. Oct 03, 2017
    • Akihiko Odaki's avatar
      Validate id of ActivityPub representations (#5114) · 63f09797
      Akihiko Odaki authored
      Additionally, ActivityPub::FetchRemoteStatusService no longer parses
      activities.
      OStatus::Activity::Creation no longer delegates to ActivityPub because
      the provided ActivityPub representations are not signed while OStatus
      representations are.
      63f09797
Loading