Skip to content
Snippets Groups Projects
  1. Sep 20, 2022
    • Jeong Arm's avatar
    • Claire's avatar
      Improve error reporting and logging when processing remote accounts (#15605) · 1145dbd3
      Claire authored
      * Add a more descriptive PrivateNetworkAddressError exception class
      
      * Remove unnecessary exception class to rescue clause
      
      * Remove unnecessary include to JsonLdHelper
      
      * Give more neutral error message when too many webfinger redirects
      
      * Remove unnecessary guard condition
      
      * Rework how “ActivityPub::FetchRemoteAccountService” handles errors
      
      Add “suppress_errors” keyword argument to avoid raising errors in
      ActivityPub::FetchRemoteAccountService#call (default/previous behavior).
      
      * Rework how “ActivityPub::FetchRemoteKeyService” handles errors
      
      Add “suppress_errors” keyword argument to avoid raising errors in
      ActivityPub::FetchRemoteKeyService#call (default/previous behavior).
      
      * Fix Webfinger::RedirectError not being a subclass of Webfinger::Error
      
      * Add suppress_errors option to ResolveAccountService
      
      Defaults to true (to preserve previous behavior). If set to false,
      errors will be raised instead of caught, allowing the caller to be
      informed of what went wrong.
      
      * Return more precise error when failing to fetch account signing AP payloads
      
      * Add tests
      
      * Fixes
      
      * Refactor error handling a bit
      
      * Fix various issues
      
      * Add specific error when provided Digest is not 256 bits of base64-encoded data
      
      * Please CodeClimate
      
      * Improve webfinger error reporting
      1145dbd3
  2. Aug 28, 2022
  3. Aug 25, 2022
  4. Aug 13, 2022
  5. Jul 05, 2022
  6. Jun 28, 2022
    • Claire's avatar
      Revamp post filtering system (#18058) · 02851848
      Claire authored
      * Add model for custom filter keywords
      
      * Use CustomFilterKeyword internally
      
      Does not change the API
      
      * Fix /filters/edit and /filters/new
      
      * Add migration tests
      
      * Remove whole_word column from custom_filters (covered by custom_filter_keywords)
      
      * Redesign /filters
      
      Instead of a list, present a card that displays more information and handles
      multiple keywords per filter.
      
      * Redesign /filters/new and /filters/edit to add and remove keywords
      
      This adds a new gem dependency: cocoon, as well as a npm dependency:
      cocoon-js-vanilla. Those are used to easily populate and remove form fields
      from the user interface when manipulating multiple keyword filters at once.
      
      * Add /api/v2/filters to edit filter with multiple keywords
      
      Entities:
      - `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context`
        `keywords`
      - `FilterKeyword`: `id`, `keyword`, `whole_word`
      
      API endpoits:
      - `GET /api/v2/filters` to list filters (including keywords)
      - `POST /api/v2/filters` to create a new filter
        `keywords_attributes` can also be passed to create keywords in one request
      - `GET /api/v2/filters/:id` to read a particular filter
      - `PUT /api/v2/filters/:id` to update a new filter
        `keywords_attributes` can also be passed to edit, delete or add keywords in
         one request
      - `DELETE /api/v2/filters/:id` to delete a particular filter
      - `GET /api/v2/filters/:id/keywords` to list keywords for a filter
      - `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a
         filter
      - `GET /api/v2/filter_keywords/:id` to read a particular keyword
      - `PUT /api/v2/filter_keywords/:id` to edit a particular keyword
      - `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword
      
      * Change from `irreversible` boolean to `action` enum
      
      * Remove irrelevent `irreversible_must_be_within_context` check
      
      * Fix /filters/new and /filters/edit with update for filter_action
      
      * Fix Rubocop/Codeclimate complaining about task names
      
      * Refactor FeedManager#phrase_filtered?
      
      This moves regexp building and filter caching to the `CustomFilter` class.
      
      This does not change the functional behavior yet, but this changes how the
      cache is built, doing per-custom_filter regexps so that filters can be matched
      independently, while still offering caching.
      
      * Perform server-side filtering and output result in REST API
      
      * Fix numerous filters_changed events being sent when editing multiple keywords at once
      
      * Add some tests
      
      * Use the new API in the WebUI
      
      - use client-side logic for filters we have fetched rules for.
        This is so that filter changes can be retroactively applied without
        reloading the UI.
      - use server-side logic for filters we haven't fetched rules for yet
        (e.g. network error, or initial timeline loading)
      
      * Minor optimizations and refactoring
      
      * Perform server-side filtering on the streaming server
      
      * Change the wording of filter action labels
      
      * Fix issues pointed out by linter
      
      * Change design of “Show anyway” link in accordence to review comments
      
      * Drop “irreversible” filtering behavior
      
      * Move /api/v2/filter_keywords to /api/v1/filters/keywords
      
      * Rename `filter_results` attribute to `filtered`
      
      * Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer
      
      * Fix systemChannelId value in streaming server
      
      * Simplify code by removing client-side filtering code
      
      The simplifcation comes at a cost though: filters aren't retroactively
      applied anymore.
      02851848
  7. Jun 11, 2022
  8. Jun 09, 2022
    • Eugen Rochko's avatar
      Change brand color and logotypes (#18592) · 45aa5781
      Eugen Rochko authored
      - Add rake task for generating Apple/Android icons and favicons from SVG
      - Add rake task for generating PNG icons and logos for e-mails from SVG
      - Remove obsolete Microsoft icons and configuration
      - Remove PWA shortcut icons
      45aa5781
  9. Jun 01, 2022
  10. May 26, 2022
  11. May 22, 2022
  12. May 18, 2022
  13. May 09, 2022
  14. May 03, 2022
  15. May 02, 2022
  16. Apr 29, 2022
  17. Apr 28, 2022
  18. Apr 26, 2022
  19. Apr 08, 2022
    • Eugen Rochko's avatar
    • 0x2019's avatar
      Fix error resposes for `from` search prefix (#17963) · 01253745
      0x2019 authored
      * Fix error responses in `from` search prefix (addresses mastodon/mastodon#17941)
      
      Using unsupported prefixes now reports a 422; searching for posts from an
      account the instance is not aware of reports a 404. TODO: The UI for this
      on the front end is abysmal.
      
      Searching `from:username@domain` now succeeds when `domain` is the local
      domain; searching `from:@username(@domain)?` now works as expected.
      
      * Remove unused methods on new Error classes as they are not being used
      
      Currently when `raise`d there are error messages being supplied, but
      this is not actually being used. The associated `raise`s have been
      edited accordingly.
      
      * Remove needless comments
      
      * Satisfy rubocop
      
      * Try fixing tests being unable to find AccountFindingConcern methods
      
      * Satisfy rubocop
      
      * Simplify `from` prefix logic
      
      This incorporates @ClearlyClaire's suggestion (see
      https://github.com/mastodon/mastodon/pull/17963#pullrequestreview-933986737).
      
      Accepctable account strings in `from:` clauses are more lenient than
      before this commit; for example, `from:@user@example.org@asnteo +cat`
      will not error, and return posts by @user@example.org containing the
      word "cat". This is more consistent with how Mastodon matches mentions
      in statuses. In addition, `from` clauses will not be checked for
      syntatically invalid usernames or domain names, simply 404ing when
      `Account.find_remote!` raises ActiveRecord::NotFound.
      
      New code for this PR that is no longer used has been removed.
      01253745
    • Eugen Rochko's avatar
  20. Apr 07, 2022
  21. Apr 06, 2022
  22. Apr 01, 2022
  23. Mar 30, 2022
  24. Mar 26, 2022
  25. Mar 21, 2022
  26. Mar 17, 2022
  27. Mar 15, 2022
  28. Mar 12, 2022
  29. Mar 07, 2022
    • Claire's avatar
      Add more migration tests (#17710) · 61ae6b35
      Claire authored
      * Add migration tests for hide_network settings migration
      
      * Add tests about suspended/suspended_at
      
      * Add more tests regarding the results of migrations
      
      * Fix migration test regarding stale conflicting remote account
      
      * Add migration tests about AccountConversation
      61ae6b35
  30. Mar 06, 2022
  31. Feb 23, 2022
Loading