Skip to content
Snippets Groups Projects
  1. Dec 30, 2021
  2. Dec 28, 2021
  3. Dec 26, 2021
  4. Dec 20, 2021
  5. Dec 17, 2021
  6. Dec 15, 2021
  7. Dec 13, 2021
  8. Dec 05, 2021
  9. Nov 29, 2021
  10. Nov 28, 2021
  11. Nov 26, 2021
  12. Nov 25, 2021
  13. Nov 24, 2021
    • Claire's avatar
      Fix error when suspending user with an already-existing canonical email block (#17036) · 02a87431
      Claire authored
      * Fix error when suspending user with an already-existing canonical email block
      
      Fixes #17033
      
      While attempting to create a `CanonicalEmailBlock` with an existing hash would
      raise an `ActiveRecord::RecordNotUnique` error, this being done within a
      transaction would cancel the whole transaction. For this reason, checking for
      uniqueness in Rails would query the database within the transaction and avoid
      invalidating the whole transaction for this reason.
      
      A race condition is still possible, where multiple accounts sharing a canonical
      email would be blocked in concurrent transactions, in which only one would
      succeed, but that is way less likely to happen that the current issue, and can
      always be retried after the first failure, unlike the current situation.
      
      * Add tests
      02a87431
  14. Nov 19, 2021
  15. Nov 18, 2021
  16. Nov 14, 2021
    • Claire's avatar
      Fix confusing error when webfinger request returns empty document (#16986) · 3517867b
      Claire authored
      For some reason, some misconfigured servers return an empty document when
      queried over webfinger. Since an empty document does not lead to a parse
      error, the error is not caught properly and triggers uncaught exceptions
      later on.
      
      This PR fixes that by immediately erroring out with `Webfinger::Error` on
      getting an empty response.
      3517867b
  17. Nov 13, 2021
  18. Nov 05, 2021
    • Claire's avatar
      Fix reviving revoked sessions and invalidating login (#16943) · 6da135a4
      Claire authored
      Up until now, we have used Devise's Rememberable mechanism to re-log users
      after the end of their browser sessions. This mechanism relies on a signed
      cookie containing a token. That token was stored on the user's record,
      meaning it was shared across all logged in browsers, meaning truly revoking
      a browser's ability to auto-log-in involves revoking the token itself, and
      revoking access from *all* logged-in browsers.
      
      We had a session mechanism that dynamically checks whether a user's session
      has been disabled, and would log out the user if so. However, this would only
      clear a session being actively used, and a new one could be respawned with
      the `remember_user_token` cookie.
      
      In practice, this caused two issues:
      - sessions could be revived after being closed from /auth/edit (security issue)
      - auto-log-in would be disabled for *all* browsers after logging out from one
        of them
      
      This PR removes the `remember_token` mechanism and treats the `_session_id`
      cookie/token as a browser-specific `remember_token`, fixing both issues.
      6da135a4
    • Claire's avatar
      87085a51
    • Eugen Rochko's avatar
      Add support for structured data and more OpenGraph tags to link cards (#16938) · 39cdf61a
      Eugen Rochko authored
      Save preview cards under their canonical URL
      
      Increase max redirects to follow from 2 to 3
      39cdf61a
    • Claire's avatar
      Fix handling announcements with links (#16941) · 989c67d2
      Claire authored
      Broken since #15827
      989c67d2
  19. Nov 04, 2021
  20. Oct 28, 2021
Loading