Skip to content
Snippets Groups Projects
  1. Aug 19, 2020
  2. Aug 12, 2020
    • ThibG's avatar
      Improve email address validation (#14565) · 8d217d72
      ThibG authored
      * Increase DNS timeout from 1 second to 5 seconds for MX check
      
      1 seconds is rather short when using a recursive DNS resolver which
      hasn't got a cached result already available. Use 5 seconds instead,
      which is the timeout value we use for outgoing HTTP queries.
      
      * Add more precise error messages for invalid e-mail addresses
      Unverified
      8d217d72
  3. Aug 02, 2020
    • ThibG's avatar
      Change content-type to be always computed from file data (#14452) · a1412491
      ThibG authored
      * Change content-type to be always computed from file data
      
      Restore previous behavior, detecting the content-type isn't very
      expensive, and some instances may serve files as application/octet-stream
      regardless of their true type, making fetching media from them fail, while
      it used to work pre-3.2.0.
      
      * Add test
      Unverified
      a1412491
  4. Aug 01, 2020
  5. Jul 22, 2020
    • ThibG's avatar
      Fix not handling Undo on some activity types when they aren't inlined (#14346) · 5d9acc0c
      ThibG authored
      * Fix not handling Undo on some activity types when they aren't inlined
      
      When receiving an Undo for a non-inlined activity, try looking it up in
      database using the URI. The queries are ad-hoc because we don't have a global
      index of object URIs, and not all activity types are stored in database with
      an index on their URI.
      
      Announces are just statuses, and have an index on URIs, so this check can
      be done efficiently.
      
      Accepts cannot be handled at all because we don't record their URI at any
      point.
      
      Follows don't have an index on URI, but they have an index on the issuing
      account, which should make such queries largely manageable.
      
      Likes don't have an index on URI, they have an index on the issuing account,
      but the number of favs per account may be very high, so I decided not to
      handle that.
      
      Blocks don't have an index on URI, but they have an index on the issuing
      account, which should make such queries largely manageable.
      
      In all cases, if an Undo could not be handled properly, we call `delete_later!`
      because that does not require us to know more than the URI of the undone
      property.
      
      * Add tests
      
      * Make newer blocks overwrite older ones
      
      Allows re-synchronizing block info by re-blocking and un-blocking again
      when the original Undo Block has been lost.
      Unverified
      5d9acc0c
    • ThibG's avatar
      Fix RSS feeds not being cachable (#14368) · f55dd193
      ThibG authored
      * Add tests for some cachable responses
      
      This only covers responses that we should have managed to make cachable
      so far. It's not the case of all responses that should be cachable in
      the end.
      
      * Fix RSS feeds not being cachable
      Unverified
      f55dd193
  6. Jul 17, 2020
  7. Jul 15, 2020
  8. Jul 07, 2020
  9. Jul 01, 2020
    • ThibG's avatar
      Change move handler to carry blocks over (#14144) · 35cedc92
      ThibG authored
      * Change move handler to carry blocks and mutes over
      
      When user A blocks user B and B moves to a new account C, make A block C
      accordingly.
      
      Note that it only works if A's instance is aware of the Move, that is,
      if B is on A's instance or has followers there.
      
      * Also notify instances with known people blocking you when moving
      
      * Add automatic account notes when blocking/muting an account that had no note
      Unverified
      35cedc92
  10. Jun 30, 2020
    • Eugen Rochko's avatar
    • ThibG's avatar
      Add user notes on accounts (#14148) · 65506bac
      ThibG authored
      * Add UserNote model
      
      * Add UI for user notes
      
      * Put comment in relationships entity
      
      * Add API to create user notes
      
      * Copy user notes to new account when receiving a Move activity
      
      * Address some of the review remarks
      
      * Replace modal by inline edition
      
      * Please CodeClimate
      
      * Button design changes
      
      * Change design again
      
      * Cancel note edition when pressing Escape
      
      * Fixes
      
      * Tweak design again
      
      * Move “Add note” item, and allow users to add notes to themselves
      
      * Rename UserNote into AccountNote, rename “comment” Relationship attribute to “note”
      Unverified
      65506bac
  11. Jun 29, 2020
  12. Jun 09, 2020
    • ThibG's avatar
      Make domain block/silence/reject-media code more robust (#13424) · 89f40b6c
      ThibG authored
      * Split media cleanup from reject-media domain blocks to its own service
      
      * Slightly improve ClearDomainMediaService error handling
      
      * Lower DomainClearMediaWorker to lowest-priority queue
      
      * Do not catch ActiveRecord::RecordNotFound in domain block workers
      
      * Fix DomainBlockWorker spec labels
      
      * Add some specs
      
      * Change domain blocks to immediately mark accounts as suspended
      
      Rather than doing so sequentially, account after account, while cleaning
      their data. This doesn't change much about the time the block takes to
      complete, but it immediately prevents interaction with the blocked domain,
      while up to now, it would only be guaranteed when the process ends.
      Unverified
      89f40b6c
    • Eugen Rochko's avatar
  13. Jun 04, 2020
  14. Jun 02, 2020
  15. May 15, 2020
  16. May 14, 2020
  17. May 12, 2020
  18. May 10, 2020
  19. May 08, 2020
  20. May 03, 2020
  21. Apr 25, 2020
  22. Apr 15, 2020
  23. Apr 03, 2020
  24. Mar 31, 2020
  25. Mar 25, 2020
    • ThibG's avatar
      Fix media not being marked sensitive when client sets a CW but no text (#13277) · f08f880f
      ThibG authored
      Mastodon enforces the “sensitive” flag on media attachments whenever a toot
      is posted with a Content Warning. However, it does so *after* potentially
      converting the Content Warning to toot text (when there is no toot text),
      which leads to inconsistent and surprising behavior for API clients.
      This commit fixes this inconsistency.
      Unverified
      f08f880f
  26. Mar 21, 2020
Loading