Skip to content
Snippets Groups Projects
  1. Sep 22, 2017
  2. Sep 20, 2017
    • aschmitz's avatar
      Change IDs to strings rather than numbers in API JSON output (#5019) · 669fe9ee
      aschmitz authored
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Back out RelationshipsController Change
      
      This was made to make a test a bit less flakey, but has nothing to
      do with this branch.
      
      * Change internal streaming payloads to stringified IDs as well
      
      Per
      https://github.com/tootsuite/mastodon/pull/5019#issuecomment-330736452
      we need these changes to send deleted status IDs as strings, not
      integers.
      669fe9ee
  3. Sep 19, 2017
    • Akihiko Odaki's avatar
      Introduce OStatus::TagManager (#5008) · bb4d005a
      Akihiko Odaki authored
      bb4d005a
    • Eugen Rochko's avatar
      Custom emoji (#4988) · 81cec35d
      Eugen Rochko authored
      * Custom emoji
      
      - In OStatus: `<link rel="emoji" name="coolcat" href="http://..." />`
      - In ActivityPub: `{ type: "Emoji", name: ":coolcat:", href: "http://..." }`
      - In REST API: Status object includes `emojis` array (`shortcode`, `url`)
      - Domain blocks with reject media stop emojis
      - Emoji file up to 50KB
      - Web UI handles custom emojis
      - Static pages render custom emojis as `<img />` tags
      
      Side effects:
      
      - Undo #4500 optimization, as I needed to modify it to restore
        shortcode handling in emojify()
      - Formatter#plaintext should now make sure stripped out line-breaks
        and paragraphs are replaced with newlines
      
      * Fix emoji at the start not being converted
      81cec35d
  4. Sep 17, 2017
  5. Sep 16, 2017
  6. Sep 14, 2017
  7. Sep 13, 2017
    • Eugen Rochko's avatar
      Uploads for admin site settings (#4913) · 9239e4ce
      Eugen Rochko authored
      * Improve OpenGraph tags for about pages
      
      * Add thumbnail admin setting
      
      * Fix error
      
      * Fix up
      9239e4ce
    • ThibG's avatar
      Fix ActivityPub handling of replies with WEB_DOMAIN (#4895) (#4904) · 550ff677
      ThibG authored
      * Fix ActivityPub handling of replies when LOCAL_DOMAIN ≠ WEB_DOMAIN (#4895)
      
      For all intents and purposes, `local_url?` is used to check if an URL refers
      to the Web UI or the various API endpoints of the local instances. Those things
      reside on `WEB_DOMAIN` and not `LOCAL_DOMAIN`.
      
      * Change local_url? spec, as all URLs handled by Mastodon are based on WEB_DOMAIN
      550ff677
  8. Sep 12, 2017
  9. Sep 11, 2017
  10. Sep 10, 2017
  11. Sep 09, 2017
  12. Sep 08, 2017
  13. Sep 07, 2017
  14. Sep 06, 2017
    • Eugen Rochko's avatar
      Switch to static URIs, new URI format in both protocols for new statuses (#4815) · e7adbf57
      Eugen Rochko authored
      * Decouple Status#local? from uri being nil
      
      * Replace on-the-fly URI generation with stored URIs
      
      - Generate URI in after_save hook for local statuses
      - Use static value in TagManager when available, fallback to tag format
      - Make TagManager use ActivityPub::TagManager to understand new format
      - Adjust tests
      
      * Use other heuristic for locality of old statuses, do not perform long query
      
      * Exclude tombstone stream entries from Atom feed
      
      * Prevent nil statuses from landing in Pubsubhubbub::DistributionWorker
      
      * Fix URI not being saved (#4818)
      
      * Add more specs for Status
      
      * Save generated uri immediately
      
      and also fix method order to minimize diff.
      
      * Fix alternate HTML URL in Atom
      
      * Fix tests
      
      * Remove not-null constraint from statuses migration to speed it up
      e7adbf57
  15. Sep 05, 2017
  16. Sep 04, 2017
  17. Sep 02, 2017
  18. Sep 01, 2017
    • Eugen Rochko's avatar
      Make PreviewCard records reuseable between statuses (#4642) · 7dc50350
      Eugen Rochko authored
      * Make PreviewCard records reuseable between statuses
      
      **Warning!** Migration truncates preview_cards tablec
      
      * Allow a wider thumbnail for link preview, display it in horizontal layout (#4648)
      
      * Delete preview cards files before truncating
      
      * Rename old table instead of truncating it
      
      * Add mastodon:maintenance:remove_deprecated_preview_cards
      
      * Ignore deprecated_preview_cards in schema definition
      
      * Fix null behaviour
      7dc50350
  19. Aug 31, 2017
  20. Aug 30, 2017
  21. Aug 29, 2017
  22. Aug 28, 2017
  23. Aug 26, 2017
  24. Aug 25, 2017
Loading