Skip to content
Snippets Groups Projects
  1. Oct 06, 2021
    • Claire's avatar
      Fix media attachment size validation not correctly accounting for file type (#16819) · 84ceebe1
      Claire authored
      * Fix media attachment size validation not correctly accounting for file type
      
      Fixes a regression introduced in #16724 caused by the fact that kt-paperclip
      now correctly runs validations before processing, meaning that file size
      verification could not rely on our before_post_processing hook.
      
      Moved the `before_post_processing` hooks to `before_validate` to make sure
      the media attachment type is set correctly before the file gets validated.
      
      * Add tests
      Unverified
      84ceebe1
  2. Sep 30, 2021
  3. Sep 29, 2021
    • Claire's avatar
      Switch from unmaintained paperclip to kt-paperclip (#16724) · fc3ae134
      Claire authored
      * Switch from unmaintained paperclip to kt-paperclip
      
      * Drop some compatibility monkey-patches not required by kt-paperclip
      
      * Drop media spoof check monkey-patching
      
      It's broken with kt-paperclip and hopefully it won't be needed anymore
      
      * Fix regression introduced by paperclip 6.1.0
      
      * Do not rely on pathname to call FastImage
      
      * Add test for ogg vorbis file with cover art
      
      * Add audio/vorbis to the accepted content-types
      
      This seems erroneous as this would be the content-type for a vorbis stream
      without an ogg container, but that's what the `marcel` gem outputs, so…
      
      * Restore missing for_as_default method
      
      * Refactor Attachmentable concern and delay Paperclip's content-type spoof check
      
      Check for content-type spoofing *after* setting the extension ourselves, this
      fixes a regression with kt-paperclip's validations being more strict than
      paperclip 6.0.0 and rejecting some Pleroma uploads because of unknown
      extensions.
      
      * Please CodeClimate
      
      * Add audio/vorbis to the unreliable set
      
      It doesn't correspond to a file format and thus has no extension associated.
      Unverified
      fc3ae134
  4. Sep 27, 2021
    • Claire's avatar
      Fix incorrect use of old WebUI paths (#16773) · 6b19e1e6
      Claire authored
      * Fix incorrect use of old WebUI paths
      
      PR #16171 renamed some routes but missed some occurrences.
      Without #16772, this leads to unreachable routes in those cases.
      
      * Fix floating action button being displayed on statuses and compose screen
      Unverified
      6b19e1e6
    • Claire's avatar
      Add aliases for WebUI routes that were renamed in #16171 (#16772) · 11502ae4
      Claire authored
      * Add aliases for some WebUI routes that were renamed in #16171
      
      Accounts and statuses routes need more work as they use different parameters.
      
      * Add aliases for /statuses/* routes
      
      * Add aliases for /accounts/* WebUI routes
      
      Does not correctly set the “active” state on the navigation tabs but this is
      a minor issue.
      
      * Fix some routes
      
      * Fix /accounts/:id/{media,followers,following} not loading on legacy routes
      Unverified
      11502ae4
  5. Sep 26, 2021
  6. Sep 15, 2021
  7. Sep 13, 2021
    • Claire's avatar
      Stop setting a shortcode to newly-created media attachments (#16730) · db57bff1
      Claire authored
      * Stop setting a shortcode to newly-created media attachments
      
      The WebUI has stopped using the “short media URL” in ages. This isn't used
      anywhere except for mail notifications.
      
      Deprecating it would allow us to eventually get rid of at least a database
      column and corruption-prone index, as well as a controller.
      
      * Fix tests
      Unverified
      db57bff1
  8. Sep 08, 2021
  9. Sep 01, 2021
  10. Aug 26, 2021
  11. Aug 25, 2021
  12. Aug 20, 2021
  13. Aug 11, 2021
  14. Aug 09, 2021
    • Claire's avatar
      Add feature to automatically delete old toots (#16529) · 4ac78e2a
      Claire authored
      * Add account statuses cleanup policy model
      
      * Record last inspected toot to delete to speed up successive calls to statuses_to_delete
      
      * Add service to cleanup a given account's statuses within a budget
      
      * Add worker to go through account policies and delete old toots
      
      * Fix last inspected status id logic
      
      All existing statuses older or equal to last inspected status id must be
      kept by the current policy. This is an invariant that must be kept so that
      resuming deletion from the last inspected status remains sound.
      
      * Add tests
      
      * Refactor scheduler and add tests
      
      * Add user interface
      
      * Add support for discriminating based on boosts/favs
      
      * Add UI support for min_reblogs and min_favs, rework UI
      
      * Address first round of review comments
      
      * Replace Snowflake#id_at_start with with_random parameter
      
      * Add tests
      
      * Add tests for StatusesCleanupController
      
      * Rework settings page
      
      * Adjust load-avoiding mechanisms
      
      * Please CodeClimate
      Unverified
      4ac78e2a
    • Takeshi Umeda's avatar
  15. Aug 08, 2021
  16. Aug 06, 2021
  17. Aug 05, 2021
  18. Jul 24, 2021
  19. Jul 23, 2021
  20. Jul 21, 2021
  21. Jul 17, 2021
    • Claire's avatar
      Fix replying from modal (#16516) · e54a6501
      Claire authored
      Fixes #16515
      
      Not using a router object somehow made `this.history` lag behind the real
      browser history whenever pushing a new history item in `replyCompose`.
      
      Not using the context-provided router in this case was an oversight made
      when porting glitch-soc changes in #16499.
      Unverified
      e54a6501
  22. Jul 15, 2021
    • Claire's avatar
      Fix inefficiencies in auto-linking code (#16506) · 211d5c3c
      Claire authored
      The auto-linking code basically rewrote the whole string escaping non-ascii
      characters in an inefficient way, and building a full character offset map
      between the unescaped and escaped texts before sending the contents to
      TwitterText's extractor.
      
      Instead of doing that, this commit changes the TwitterText regexps to include
      valid IRI characters in addition to valid URI characters.
      Unverified
      211d5c3c
  23. Jul 14, 2021
Loading